fix(reactivity): make it possible to get the computed's value in the unmounted hook #3528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HcySunYang
added
the
🔨 p3-minor-bug
|
Good job tracing this down to 29be536b1f0b7f7f7c1e6cd5a84e12bb4c48b87c - I believe that was a bad fix because the problem in #910 should be a scheduler concern instead of the reactivity module. So I reverted the fix in 29be536b1f0b7f7f7c1e6cd5a84e12bb4c48b87c and fixed it in the scheduler instead in 03a7a73 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #3099
#3099 is caused by this commit 29be536, and this commit 29be536 used to solve problem #910.
In this PR, I introduced the new effect option
allowInactiveRun, so that we can specify whether a side effect fn can be executed in inactive